Teatime tests (and fixes) #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice work |
DizzyEggg
approved these changes
Jul 3, 2023
DizzyEggg
approved these changes
Jul 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for Teatime and fixes some interactions.
Description
I noticed Teatime would skip some Pokémon. For example, when not being used by the player, the player Pokémon would not consume its berry.
I added some tests based on the very niche interactions around Electrify/Plasma Fists and Volt Absorb, Lightning Rod and Motor Drive, which should trigger their effects (heal, raise Sp. Atk or raise Speed.) These interactions are based on what Bulbapedia and Pokémon Showdown do, as I'm not able to test this interaction in an official game. If this is a problem, I'm happy to revert to the old behaviour with regards to these abilities.
Discord contact info
hetoord